search

drunomics / nuxtjs-drupal-ce

A Nuxt module to easily connect Drupal via custom elements.
https://lupus-decoupled.org/
MIT License
22 stars 4 forks source link

Nuxt 3 compatibility #93

Closed TurtlBbx closed 1 year ago

TurtlBbx commented 1 year ago

Provide the folowing helpers: const { renderCustomElements, getMenu, getCurrentPage, fetchPage, lazyFetchPage } = useDrupalCe()

TurtlBbx commented 1 year ago

WIP: feature/LDP-1851

TurtlBbx commented 1 year ago

PR: https://github.com/drunomics/nuxtjs-drupal-ce/pull/99

fago commented 1 year ago

thx. I think this is pretty good already. I see your point with the useDrupalCeFetchMenu syntax and it's better now without imports, but I'm not 100% convinced. Maybe something like useDrupalCe().fetchMenu() would work? but in the end we should stick to general nuxt conventions here. I'd suggest we merge first PR with what we have now and then clarify best syntax in a dedicated issue / PR.

So I think for merging this, we should just make sure we have a complete TODO list of open items, so we do not forgot anything. Maybe add the list of TODOs in the README or have a separate github issue where we keep track of it?

fago commented 1 year ago

Solved in 2.x