search

drupal-composer / drupal-packagist

:package: Drupal Packagist server to automatically build package information from projects on drupal.org
http://packagist.drupal-composer.org
28 stars 4 forks source link

Drupal profiles with patches in makefile #29

Closed derhasi closed 7 years ago

derhasi commented 9 years ago

To make certain drupal profiles work out of the box patches must be applied: for example see http://cgit.drupalcode.org/erpal_platform/tree/drupal-org.make?id=7.x-1.0-alpha9

This could be resolved when we can standardize on a patch workflow and are also available to provide patch information in a package. We might have a look at security though.

see https://github.com/drupal-composer/drupal-project/issues/14

grasmash commented 8 years ago

+1 for this.

I assume that we'll need to listen to an event that fires after a package has been downloaded, check the package directory for files like:

Loading build-{$project-name}.make should be sufficient. We can then use make_parse_info_file() from drush to parse the make file, and perhaps dynamically add the dependencies to the require array? That, or perhaps generate a subsidiary composer.json for the package on the fly (assuming it doesn't have one).

Could use something like this for generating the new one: https://github.com/grasmash/drush/blob/master/commands/make/make.drush.inc#L429

Anyone know where to start with this? I can fork and give it a shot.

webflo commented 8 years ago

@grasmash Are you still interested in this? Does cweagans/composer-patches work recursive?

grasmash commented 8 years ago

I'm still interested, but I've found a stopgap that addresses my needs in the mean time. It requires that the installation profile support composer.

Steps for profile maintainer:

This requires a bit of extra work on the profile maintainer's part and doesn't completely solve the problem.