Fix version constraints for short versions

drupal-composer / drupal-parse-composer

:mag: Components used in Drupal-Packagist to parse package information from drupal.org

10 stars 11 forks source link

Fix version constraints for short versions #16

Closed webflo closed 9 years ago

webflo commented 9 years ago

Fixes #7

webflo commented 9 years ago

@winmillwill @generalredneck please review.

derhasi commented 9 years ago

Looks fine to me. Fell free to merge it.

winmillwill commented 9 years ago

Your spec tests what I wanted to test, and it passes, so that's all good.

On design, it seems like this should functionality should live in separate types, because we really have separate types of versions. The version class is a mess, so I won't insist on that at this point. Everything else seems reasonable, aside from the indentation, which is being addressed by another PR anyway, but I suppose we should have contributing notes about not adjusting style in a PR that addresses anything else.