Protect against missing result value

drupal-composer / drupal-scaffold

:construction: Composer Plugin for updating the Drupal scaffold files when using drupal/core

190 stars 46 forks source link

Closed sherakama closed 6 years ago

sherakama commented 6 years ago

When running composer drupal:scaffold I was returned with the error

[ErrorException]
  Undefined index: errors

Tracing through the problem it came to the errors key in the $result. It did not exist for me.

My setup

PHP: 7.1.20 drupal-composer/drupal-scaffold: 2.5.3 hirak/prestissimo: 0.3.6 (installed globally) drupal/core: 8.5.5 Composer: 1.4.1

webflo commented 6 years ago

Makes sense, this has been changed in prestissimo 0.3.7.

sherakama commented 6 years ago

Ah, does makes sense.

I will update my local version to 0.3.7.

As prestissimo is not a requirement and drupal-scaffold cannot put in a version constraint this PR is still valid IMHO.

Thanks!

danielnv18 commented 6 years ago

Confirming that it works in master (hash: fc6bf4c) could any maintainer make a release? thank for the awesome work

webflo commented 6 years ago