search

drupal-docker / php

Dockerized PHP for Drupal :droplet::whale:
https://hub.docker.com/r/drupaldocker/php/
MIT License
38 stars 51 forks source link

Policy about adding additional PHP extensions #28

Open slashrsm opened 8 years ago

slashrsm commented 8 years ago

A lot of times one needs to add additional PHP extensions. While some of them are solving very custom requirements others can be more common. For example, I'd need redis support. What is the policy about that? Is it possible to add more extensions or should we create a fork and own build?

zaporylie commented 8 years ago

Hi @slashrsm

Sorry for late response but I was away from my computer due to holiday season in Norway. I don't see any major issues to add Redis extension to generic PHP images.

Minor issues:

I think those minor issues are acceptable. I believe we could also create drupaldocker/redis which is 1-to-1 copy of official Redis (see drupaldocker/elasticsearch for reference).

I hope we can meet and discuss topics related to drupal-docker initiative (i.e. php extensions policy) during DDD Milano.

zaporylie commented 8 years ago

I the mean time I've created https://github.com/drupal-docker/redis and gave you write permission. Feel free to fill it with Dockerimages.

slashrsm commented 8 years ago

Thank you for your feedback.

I believe we could also create drupaldocker/redis which is 1-to-1 copy of official Redis (see drupaldocker/elasticsearch for reference).

What is the benefit of maintaining an image that is exact copy of the default one?

I hope we can meet and discuss topics related to drupal-docker initiative (i.e. php extensions policy) during DDD Milano.

Sure, that would be great! There is also a session about Docker it seems: http://milan2016.drupaldays.org/node/137

zaporylie commented 8 years ago

What is the benefit of maintaining an image that is exact copy of the default one?

We can instruct people (i.e. in docker-compose.yml) to use images from our namespace (vendor). Images which will be always compatible with Drupal. Right now there's probably nothing to be added to official Redis image but I expect one day we might want to ship it with additional .conffile.

I believe this is small step for us right now. Almost nothing to maintain, since it will be automatically synced with base image, but adds much more flexibility for the future.

iBobik commented 6 years ago

How about to reconsider extensions with the radmap (#83) in mind - moving to alpine-only?

I think it is not justifiable to add extensions what will not be used on most of projects, e.g. Redis, Memcached. Also alternative DB drivers should be considered - pdo_pgsql and it's deps.