Add dev versions of images (with xdebug)

drupal-docker / php

Dockerized PHP for Drupal :droplet::whale:

https://hub.docker.com/r/drupaldocker/php/

MIT License

38 stars 51 forks source link

Add dev versions of images (with xdebug) #30

Closed slashrsm closed 8 years ago

slashrsm commented 8 years ago

Rebased #6 and added dev versions of fpm and cli images.

zaporylie commented 8 years ago

Thanks for pushing it forward.

I was actually thinking about creating separate branch OR repo for php-dev images:

drupaldocker/php => drupaldocker/php-dev
drupaldocker/php:7 => drupaldocker/php-dev:7
drupaldocker/php:7-apache => drupaldocker/php-dev:7-apache

IMO it will make it easier to maintain&use php-dev images.

Example Dockerfile as in d486a48:

FROM drupaldocker/php:5.5-cli
MAINTAINER drupal-docker <info@drupaldocker.org>

RUN pecl install xdebug-beta \
  && docker-php-ext-enable xdebug

COPY xdebug.ini /usr/local/etc/php/conf.d/

slashrsm commented 8 years ago

Yes, a separate branch or repo would do. It would make sense for it to have the common history with the master branch for easier merges/rebases. Maybe a branch in the same repo?

When we decide I'll be happy to finish it.

slashrsm commented 8 years ago

So what we decided? "dev" branch?

slashrsm commented 8 years ago

Rebased and prepared images to live in a separate branch. Will leave it as PR for now. When it is ready we can just push the branch and close it.

slashrsm commented 8 years ago

Rebased. Anything else that need to be done for this to be promoted to Docker hub?

zaporylie commented 8 years ago

Sorry for delay.

I created branch, cherry-picked your last commit and configured php-dev image on Docker hub. It needs polishing but we have starting point at least.