drupal-docker / php

Dockerized PHP for Drupal :droplet::whale:
https://hub.docker.com/r/drupaldocker/php/
MIT License
38 stars 51 forks source link

Add alpine versions of images. #50

Closed slashrsm closed 7 years ago

slashrsm commented 8 years ago

Image size 27MB vs 150MB.

zaporylie commented 8 years ago

Failing due to missing alpine for 5.4 and missing apt-get. You may want to use apk instead

slashrsm commented 8 years ago

Green.

zaporylie commented 8 years ago

Oh... comment was actually added below 😄 still learning how to use new Github review tools.

slashrsm commented 7 years ago

Test fails seems to be unrelated since they happened in PHP 5.4 image, which we didn't touch here.

zaporylie commented 7 years ago

I have restarted that job. Feel like it's Travis infra issue.

Anyway - this stats looks impressive: 7.1-alpine latest bfaabef70542 Less than a second ago 96.38 MB 7.1-alpine/fpm latest ea039aa6c4dc Less than a second ago 89.67 MB 7.1 latest 75cc51bad7d0 Less than a second ago 434.7 MB 7.1/fpm latest 3f0f00c4af23 Less than a second ago 408.9 MB

slashrsm commented 7 years ago

Agreed! What can we do regarding Travis? Wait?

zaporylie commented 7 years ago

Just got alert from Docker Hub that 5.4-cli is failing there too. I will investigate later this weekend what could cause that error.

zaporylie commented 7 years ago

Ok, so "wait" was enough :) Just rerun failing build and now it's ok :) I'm gonna prepare tags on hub.docker.com and merge that pull request as soon as it's done.

slashrsm commented 7 years ago

Yay! Thanks @zaporylie.