search

drupal-docker / php

Dockerized PHP for Drupal :droplet::whale:
https://hub.docker.com/r/drupaldocker/php/
MIT License
38 stars 51 forks source link

Dockerfile conditional building #69

Open iBobik opened 7 years ago

iBobik commented 7 years ago

Currently there are directories for PHP version:

and inside are Dockerfiles:

It means 3 x 7 = 21 Dockerfiles needed to maintain.

How about to join them to one Dockerfile, but with conditions? This base Dockerfile should be build by a script, artifacts will be similar like current Dockerfiles in this repository.

zaporylie commented 7 years ago

Sorry for late response but I have extremely busy time at work.

It means 3 x 7 = 21 Dockerfiles needed to maintain.

Actually 3 x 5 = 15

How about to join them to one Dockerfile, but with conditions?

How do you imagine such a conditional build? Whole point of having separate Dockerfiles is that each image has different base image (FROM).

One of the reasons of using Dockerfiles is that Docker Hub "Automated build" integration can process it automatically either on change to this repository or official PHP Image (Base Image).

iBobik commented 6 years ago

Testing something similar on my image: https://gitlab.com/janpoboril/drupal-composer-docker

It uses GitLab CI to mirror tags of base image. Feedback wellcome.