search

drupal-docker / php

Dockerized PHP for Drupal :droplet::whale:
https://hub.docker.com/r/drupaldocker/php/
MIT License
38 stars 51 forks source link

Add exif extension to all php versions #95

Closed eiriksm closed 5 years ago

eiriksm commented 5 years ago

Exif is useful.

Also, if a project has ext-exif in their composer.json, I would like to be able to install the project.

zaporylie commented 5 years ago

In general, I'm not the biggest fan of adding php extensions which may be useful only for some people but are not the explicit drupal requirement, as I try to keep the size of the image as small as possible. I did one exception in the past - added bcmath which is not required by drupal core but it is by commerce which one of the most popular projects on d.o. I did some research and checked the size of the 7.2-fpm-2.x image before (2 months old build on travis) and after this PR and the size has reduced so much over last 2 months (upstream optimizations) so even that we add new extension the total size is still lower than it used to be. Taking all into consideration I'm ok with merging this PR, but adding info which popular module and/or distro requires ext-exif would help to ease my conscience :)

eiriksm commented 5 years ago

In this case it was a client project :)

I am fine with not having it in there