search

drupal-graphql / graphql-metatag

6 stars 13 forks source link

fix(graphql_metatag): Mark fields as secure #4

Closed joaogarin closed 6 years ago

joaogarin commented 6 years ago

I am really not sure about what this change would do and if it is even appropriate. But at lest would like to understand the implications and how this impacts the issue discussed in slack and in https://github.com/drupal-graphql/graphql-metatag/issues/3

Without this mark the query returns an Internal Server Error if you don't have for example bypass field security enabled (which no-one should I guess in normal roles or anonymous)

codecov[bot] commented 6 years ago

Codecov Report

Merging #4 into 8.x-1.x will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           8.x-1.x   #4   +/-   ##
====================================
  Coverage        0%   0%           
====================================
  Files            7    7           
  Lines           67   67           
====================================
  Misses          67   67
Impacted Files Coverage Δ
src/Plugin/GraphQL/Fields/Metatag/Value.php 0% <ø> (ø) :arrow_up:
...rc/Plugin/GraphQL/Fields/Entity/EntityMetatags.php 0% <ø> (ø) :arrow_up:
src/Plugin/GraphQL/Fields/Metatag/Key.php 0% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b787729...a921f07. Read the comment docs.