drupal-graphql / graphql-search-api

GraphQL & Drupal Search API integration.
10 stars 22 forks source link

Incorrect field names in range #20

Closed duartegarin closed 5 years ago

duartegarin commented 5 years ago

@joaogarin When we added range delimiters, we assumed that start equals offset (correct) and end equals the end of the range, when in fact it is a "limit".

This means that if I want results on page 2 (on a 5 records per page) I should specify "start" as 5 and "end" as 5.

I propose we refactor this to "offset" and "limit" to be consistent with the rest of GraphQL module implementations.

However, this is a breaking change given that all consumers need to update their implementations.

joaogarin commented 5 years ago

This sounds 👍 to me