Closed MurzNN closed 3 years ago
Soo, can anybody review my PR?
Hi @MurzNN , Thanks for the PR and apologies for the late reply, been pretty swamped lately. This looks good, just wondering why you've added a composer.json file to the module? Doesn't seem necessary. Cheers
@duartegarin About composer.json
- I added it because most of other Drupal modules already have it, for better description in composer
commands, and ability to set a requirements, if needed be.
For example, you can declare support of Drupal core versions via line like:
"require": {
"drupal/core": "^8.9 || ^9",
},
If it is not needed, I can remove it.
I think that's sensible @MurzNN , merging.
Sometimes we need to pass specific custom options to Search API Query, for example to use
search_api_location
options (example). At now there are no ability to pass raw options to Search API Query via SearchAPISearch GraphQL function.This PR adds the
options
argument, that can receive options and pass them to Search API Query.Query example:
Please review it and comment, if something need to be reworked.