search

drupal-graphql / graphql

GraphQL integration for Drupal 9/10
288 stars 202 forks source link

AlterableComposableSchema::getExtensionDocument returning NULL #1395 #1398

Closed almunnings closed 2 months ago

almunnings commented 3 months ago

GraphQL 4.x AlterableComposableSchema

If you have a schema without any extensions, and you use the AlterSchemaExtensionDataEvent to add to $extensions, the $ast will always return NULL.

Closes: https://github.com/drupal-graphql/graphql/issues/1395

klausi commented 3 months ago

Thanks! Can we test this somehow in AlterableSchemaTest?

almunnings commented 3 months ago

Oh c'mon github, I clicked a button and it's exposed me! I'll create a new MR.

klausi commented 3 months ago

I can reopen!

klausi commented 2 months ago

Thanks a lot! The test are a bit complicated, but I verified that they fail correctly without the fix.