Closed aconz2 closed 9 years ago
When you send the PR or merge to GitHub, I'll pull and push to drupal.org repository, so we can re-test. Btw. You can commit to master
, then merge the changes into 7.x-1.x
, or I could do it as well.
I've pushed your branch into drupal repository, so you can re-test if that would work.
Commits are at: https://www.drupal.org/node/1986838/commits, Home page (with tar.gz/zip files): https://www.drupal.org/project/ads
But you've to wait a bit until package manager will rebuild tar.gz
file for 7.x-1.x-dev.
If you think it should work now, I'll re-test it soon.
But actually I was thinking to rebuild in the same directory, not in src/
.
So the scenario is that I can go into public_html/
dir, then download the distribution, then inside the ads folder I want to instal it straight into public_html/ which is actually one directory up.
Like:
cd public_html
drush dl --dev
cd ads-*
phing -D out=..
So the build will generate all www files in public_html (but not in src/), without need to move the files around.
So the goal is to have 2 commands (drush & phing or make) to do the whole site built into public_html/ (without moving the files around). Eventually we could have some parameter to specify the output, so distribution is downloaded outside of public_html/, then making the build in specific folder such as public_html/ (phing -D out=/foo/public_html
or out=/foo/public_html make
). But this folder should exist.
Okay, misunderstood the use case. Will look into it more.
@aconz2 Sorry, I just seen that, it's ready already?
if it works like you want it to, then yes
@aconz2 You're probably using globbing **/*
. Is it available by default in phing
or you need to enable it via: shopt -s globstar
(if it's part of the shell syntax) somewhere?
the globbing is via phing/ant and so it doesn't depend on shopt
https://www.phing.info/docs/guide/stable/MoveTask.html which points to https://www.phing.info/docs/guide/stable/CopyTask.html
Even if this commit is merged,
drush dl --dev
will download fromhttp://updates.drupal.org/release-history/ads/7.x
and try and build a version without this commit and will fail again. So this commit needs to be in whatever version drush downloads. One way might be to merge this off master and usedrush dl ads --dev --package-handler=git_drupalorg
and thencd ads && git checkout -b feature/build-in-existing-path
and then finally,phing -D out=..
should work