drupal-modules / ads

Drupal distribution for Ads
http://drupal.org/project/ads
2 stars 2 forks source link

Don't display success message when build-drupal failed. #42

Closed kenorb closed 10 years ago

kenorb commented 10 years ago

Despite the error, ads shows the successful built message.

Example case:

$ make
build-ads > build-drupal:

Drush needs to download a library from                               [error]
http://download.pear.php.net/package/Console_Table-1.1.3.tgz in order
to function, and the attempt to download this file automatically
failed because you do not have permission to write to the library
directory /usr/share/php/drush/lib. To continue you will need to
manually download the package from
http://download.pear.php.net/package/Console_Table-1.1.3.tgz, extract
it, and copy the directory into your /usr/share/php/drush/lib
directory.

build-ads > ads-make:

build-ads > build-ads:

BUILD FINISHED

Total time: 0.1570 seconds

Human readable log output:

2014-09-13 16:48:45 --------------------------------------------------------------------------------
2014-09-13 16:48:45 Downloading and building Drupal sources... (it may take a while)
2014-09-13 16:48:45 
2014-09-13 16:48:45 Done
2014-09-13 16:48:45 
2014-09-13 16:48:45 NOTE:
2014-09-13 16:48:45 Distribution can be found in the directory: /home/x/ads/src
2014-09-13 16:48:45 You can move your newly created distribution to your webroot.
2014-09-13 16:48:45 Or you can install it by the following command:
2014-09-13 16:48:45     phing ads-install

This can be fixed by checking if project.dir.src dir exists, if not, display that the build failed.

Target: build-drupal

nseam commented 10 years ago

Duplicate of #49. Already done