search

drupal-pattern-lab / patternlab-php-core

This repository provides the core functionality for Pattern Lab. It is meant to be used from within an Edition with a PatternEngine and StarterKit.
http://patternlab.io/
MIT License
2 stars 1 forks source link

Update Pattern Lab PHP Core Minimum PHP Version to 7.0+ #16

Closed sghoweri closed 7 years ago

sghoweri commented 7 years ago

Updating the minimum PHP dependency in Pattern Lab PHP Core to PHP 7.0 to open the door for more concise ways to write out common PHP logic (ex. the Null coalescing operator - https://stackoverflow.com/a/36796941) in addition to the performance gains PHP 7 introduced.

Given that PHP 7.0 first came out nearly 2 years ago (December 3rd, 2015) I think it's about time we took the plunge...

Perhaps we could use this as a base for a major Pattern Lab PHP Core v3.0.0 release?

EvanLovely commented 7 years ago

One thing to consider is that macOS Sierra (the current OS) comes with PHP 5.6 - so basically we're saying that every person who uses PL on their machine will need to update PHP. I'm not against this, but it's something we should consider and acknowledge early.

sghoweri commented 7 years ago

Closing this last PR out. Might end up revisiting this on the main Pattern Lab repo down the road but tabling this for now.