search

drupalprojects / hotsauce

Mirror of http://drupal.org/project/hotsauce provided by hubdrop.
http://hubdrop.io/project/hotsauce
2 stars 6 forks source link

Travis CI (automate build to hotsauce-drops-7) #3

Closed pirog closed 10 years ago

pirog commented 10 years ago

@reynoldsalec @bassettsj

where are we with this?

i am moving this over from hotsauce-drops-7 so i can close that issue queue

pirog commented 10 years ago

Would be great to have some CI that tests the drush make of the distro after builds and/or on release commits also builds out and commits code for https://github.com/kalamuna/hotsauce-drops-7

reynoldsalec commented 10 years ago

We have it working CI script that allows us to run all the simple tests in the Drupal project or just a subset of them. we need to figure out what we actually want to run/what is actually useful.

There are some examples of testing Drush make processes with Travis CI I don't think that will be too hard although there should be the normal fidgeting.

On Wednesday, May 21, 2014, Mike Pirog notifications@github.com wrote:

Would be great to have some CI that tests the drush make of the distro after builds and/or on release commits also builds out and commits code for https://github.com/kalamuna/hotsauce-drops-7

— Reply to this email directly or view it on GitHubhttps://github.com/drupalprojects/hotsauce/issues/3#issuecomment-43836964 .

Please excuse any brevity, this message was sent from my phone.

pirog commented 10 years ago

@reynoldsalec that is excellent.

Do you and/or @bassettsj have any suggestions on tests that we should be running?

dsnopek commented 10 years ago

Since this appears to be a fork of Panopoly, you could also run all the Panopoly behat tests? We're already running them on Travis-CI:

https://travis-ci.org/panopoly/panopoly

I haven't tried HotSauce yet so I don't know how much it differs, but it'd be a place to start? :-)

reynoldsalec commented 10 years ago

Definitely @dsnopek, that's a great suggestion, thanks for pointing it out. Right now we've just re-namespaced Panopoly as a starting point, so it's very possible that these tests will be a perfect starting point.

pirog commented 10 years ago

+1

On Tue, May 27, 2014 at 9:10 AM, reynoldsalec notifications@github.comwrote:

Definitely @dsnopek https://github.com/dsnopek, that's a great suggestion, thanks for pointing it out. Right now we've just re-namespaced Panopoly as a starting point, so it's very possible that these tests will be a perfect starting point.

— Reply to this email directly or view it on GitHubhttps://github.com/drupalprojects/hotsauce/issues/3#issuecomment-44297656 .

Cheers,

Mike Pirog Kalamuna www.kalamuna.com

labboy0276 commented 10 years ago

Do you think you could add me as a contributor to this, i can see my fork stuff on Travis CI, but not the actual repo. OR I can just do stuff in my fork I suppose and we can figure it out later

labboy0276 commented 10 years ago

disregard, i figured it out, more to follow...

labboy0276 commented 10 years ago

OK

The final commit is as close as I could get it. It gets all the way to the end and then it gives whitelist errors and I dont know whats up with that. I copied panopoly travis.yml and made adjustments as need be

@pirog or @bassettsj do you know what these whitelist stuff is and why does it fail at the end at The command "xargs -0 -n1 drush verify-makefile" failed and exited with 123 during .

dsnopek commented 10 years ago

Drupal.org will only build distributions that include full projects (not sandbox projects) on Drupal.org OR projects on the whitelist. That check is to make sure that Drupal.org will actually build the distribution once a release is made (rather than waiting until attempting the release to see the error). If you guys aren't intending to release on Drupal.org, you can just drop that test! But if you are, check your .make file or the issue flagged by 'drush verify-makefile'.

reynoldsalec commented 10 years ago

@labboy0276 that make sense? If you have time to tackle it let me know; we will be distributing via Drupal.org eventually, but it's not über important right now, so we could just roll with things for the moment.

pirog commented 10 years ago

+1 on the @dsnopek

we have a full project on d.o so...

dsnopek commented 10 years ago

@pirog The error message from 'drupal verify-makefile' will tell you exactly what the offending project is! It could just be a matter of using the d.o download method rather than pulling the exact same code from GitHub.

pirog commented 10 years ago

@dsnopek yes.

@labboy0276 or @reynoldsalec can you provide more details on what the offending project is? are we using any additional possibly offensive non-white listed libraries? I know bootstrap used to not be on the whitelist but i think was recently added since they are GPLv2 compatible now.

labboy0276 commented 10 years ago

@pirog here are the last lines of the travis try:

Starting Drupal.org contrib makefile validation, please wait [ok] Makefile [ok] drupal/profiles/hotsauce/modules/hotsauce/hot_widgets/hot_widgets.make passed. Starting Drupal.org contrib makefile validation, please wait [ok] Makefile [ok] drupal/profiles/hotsauce/modules/hotsauce/hot_search/hot_search.make passed. Starting Drupal.org contrib makefile validation, please wait [ok] Whitelist download from http://drupal.org/packaging-whitelist/json [error] failed: connect() timed out! The Drupal.org validation check failed -- see [error] http://drupal.org/node/1432190 for more information. Starting Drupal.org contrib makefile validation, please wait [ok] Makefile [ok] drupal/profiles/hotsauce/modules/hotsauce/hot_admin/hot_admin.make passed. Starting Drupal.org contrib makefile validation, please wait [ok] Makefile [ok] drupal/profiles/hotsauce/modules/hotsauce/hot_users/hot_users.make passed. Starting Drupal.org contrib makefile validation, please wait [ok] Whitelist download from http://drupal.org/packaging-whitelist/json [error] failed: Operation timed out after 50001 milliseconds with 0 bytes received The Drupal.org validation check failed -- see [error] http://drupal.org/node/1432190 for more information. Starting Drupal.org contrib makefile validation, please wait [ok] Makefile [ok] drupal/profiles/hotsauce/modules/hotsauce/hot_pics/hot_pics.make passed. Starting Drupal.org contrib makefile validation, please wait [ok] Makefile [ok] drupal/profiles/hotsauce/modules/hotsauce/hot_core/hot_core.make passed. Starting Drupal.org contrib makefile validation, please wait [ok] Makefile [ok] drupal/profiles/hotsauce/modules/contrib/manualcrop/manualcrop.make passed. The command "xargs -0 -n1 drush verify-makefile" failed and exited with 123 during . Your build has been stopped.

reynoldsalec commented 10 years ago

@labboy0276 you should check out the Behat tests in Panopoly (see tests folder in root of Panopoly).

dsnopek commented 10 years ago

@labboy0276: Looking at the output you pasted, it looks like it was some network connectivity issue on Travis-CI. This is the key bit:

Whitelist download from http://drupal.org/packaging-whitelist/json [error]
failed: Operation timed out after 50001 milliseconds with 0 bytes
received

I'm willing to bet it was a momentary hiccup on Travis-CI's end, which does happen periodically. You can re-run the build by navigating to it in Travis-CI's interface and clicking the button in the upper right that looks like an arrow going in a circle (like a standard "refresh" button). If it was just a weird hiccup, it'll succeed when it runs again.

reynoldsalec commented 10 years ago

@labboy0276 perhaps you could take a look at @pirog's comment "Would be great to have some CI that tests the drush make of the distro after builds and/or on release commits also builds out and commits code for https://github.com/kalamuna/hotsauce-drops-7"

reynoldsalec commented 10 years ago

FYI for anyone working on this (@gremy?), until D.O. packages a new Hotsauce release, the Travis build will fail.

gremy commented 10 years ago

I'm on this issue. Found this really useful guide on how to safely commit from TravisCI. http://stackoverflow.com/questions/18027115/committing-via-travis-ci-failing

gremy commented 10 years ago

Would it be better if the Travis CI testing would be done on Pull Requests, not on individual commits? http://docs.travis-ci.com/user/pull-requests/

pirog commented 10 years ago

I think this is the ideal worfklow

  1. Submit new tag/release to hotsauce
  2. Travis attempts to builds hotsauce-drops-7
  3. If success -> submit a PR to hotsauce-drops-7 with the new code

Is that what you were thinking @gremy? @reynoldsalec does that sound good?

reynoldsalec commented 10 years ago

I think that sounds perfect @pirog, let me know if there's anything you want help on @gremy!

reynoldsalec commented 10 years ago

Ok, we have a basic test/build process that will build hotsauce to kala-travis/hotsauce-drops-7.

Some followup issues:

26: Limit access to commit to kala-travis/hotsauce-drops-7

24: Use the behat scripts Panopoly has

pirog commented 10 years ago

Random aside... for other drupal projects we might want to implement some basic linting/cs for php ala https://github.com/fluxsauce/switchboard/blob/master/.travis.yml

On Wed, Aug 13, 2014 at 3:17 PM, reynoldsalec notifications@github.com wrote:

Ok, we have a basic test/build process that will build hotsauce to kala-travis/hotsauce-drops-7.

Some followup issues:

26 https://github.com/drupalprojects/hotsauce/issues/26: Limit access

to commit to kala-travis/hotsauce-drops-7

24 https://github.com/drupalprojects/hotsauce/issues/24: Use the behat

scripts Panopoly has

— Reply to this email directly or view it on GitHub https://github.com/drupalprojects/hotsauce/issues/3#issuecomment-52119582 .

Cheers,

Mike Pirog Kalamuna www.kalamuna.com