search

drupalpune / campsite

0 stars 7 forks source link

Issues-141: Fix twitter cards styling #145

Closed siddharth7998 closed 3 months ago

siddharth7998 commented 3 months ago

In this PR, we have fixed the twitter cards styling as required here: https://github.com/drupalpune/campsite/issues/141 The cards are of variable length because we have different content length in iframes.

Screenshots

Desktop
image
Mobile
image
abhisekmazumdar commented 3 months ago

@siddharth7998 I think we will need the changes for themes/custom/camp/css/style.css as well here. I mean the compiled CSS file needs to be committed too

abhisekmazumdar commented 3 months ago

So far, the changes look good. Thank you for working on this. Just commit the updated style.css file, and we can merge it.

siddharth7998 commented 3 months ago

@abhisekmazumdar I thought these style.css changes are not required, added them now!

abhisekmazumdar commented 3 months ago

Pantheon doesn't have the option to compile the theme, nor does it have a CI/CD setup to do that. So this is the easiest way 🚀