drupalux / claro

⛔️ DEPRECATED ⛔️ Project is worked in the Drupal.org issue tracker.
https://www.drupal.org/project/claro
GNU General Public License v2.0
29 stars 15 forks source link

Apply Text area (mainly WYSIWYG editor) style updates #68

Open zolhorvath opened 5 years ago

zolhorvath commented 5 years ago

Issue

This PR fix #21.

Screenshots before/after (now Chrome on OSX only)

01--textarea--mac-os-x--chrome 02--textarea-errors--mac-os-x--chrome

Todo

Testing instructions

After that Drupal is installed, Styleguide will be the front page and you'll have the test form at /contact/textarea.

zolhorvath commented 5 years ago

@lauriii, @ckrina: this is ready for the review.

Screenshots:

Textarea screenshots - Ubuntu and Windows.zip Textarea screenshots - mobile and OSX.zip

zolhorvath commented 5 years ago

Disabled editor has to be fixed, see #74

zolhorvath commented 5 years ago

@ckrina I added an improvement for the case when Claro is the front end theme. (I think it's a very limited use case, but maybe it's worth to do so.)

However, as I see, you're using Bartik as a front end theme. Bartik provides CKEditor stylesheets as well, an in that case, CKEditor inputs are using those to provide a visual feedback for editors about how the text looks on front end theme, see the API doc about this feature (at API features / CKEditor iframe CSS / Front-end theme CSS).

ckrina commented 5 years ago

Thanks @zolhorvath ! I just changed the frontend theme to Claro too, but now it takes the styles from the core ckeditor modules and ends up using Arial instead of the system fonts, and it looks really strange having a text area with one font and the other with another one. Is there any way to change this?

arial
zolhorvath commented 5 years ago

@ckrina did you refreshed the theme?

ckrina commented 5 years ago

You're right, sorry! I forgot the yarn command. The everything good for me.