search

drupalwxt / helm-drupal

Helm Chart for deploying an enterprise-grade Drupal environment.
https://drupalwxt.github.io/helm-drupal/index.yaml
MIT License
31 stars 22 forks source link

Adding tolerations and nodeSelector support to chart #100

Closed bernardmaltais closed 3 years ago

bernardmaltais commented 3 years ago

Add support for tolerations and nodeSelector placement to Drupal9 Deployments and CronJobs

bernardmaltais commented 3 years ago

@zachomedia @sylus The mysql chart support both tolerations and nodeSelector but the statcan varnish chart does not... It would be nice if toleration and nodeSelector support was added to it also.

I have not tested the postgresql and redis chart to see if it already supported tolerations and nodeSelector... but I guess if they don't there is not much we can do short of creating a PR for those.

Having support for tolerations and nodeSelector will make it possible to deploy to Azure spot node pools for testing and training. Also allow to target specific node pool to validate the impact of a kubernetes upgrade on the chart and solution by targetting a pool that run a newer version of kubernetes.

bernardmaltais commented 3 years ago

I actually created a pull request to add the missing plumbing to the varnish chart for toleration and nodeSelector support: https://github.com/StatCan/charts/pull/48

sylus commented 3 years ago

This looks good to me but might want @zachomedia just to give it a quick glance too :D

Thanks so much for doing this!

bernardmaltais commented 3 years ago

@sylus Indeed. Pleas hold on before merging as I need to update the varnish chart to 0.2.1 since you merged it in the statcan charts repo and I will want to use that also.

bernardmaltais commented 3 years ago

OK, I think it is ready for a good review by @zachomedia I tested deploying using it to a node pool comprised of spot instance azure VM and all went well. Drupal site is up and responsive with all pods on the spot node pool... including varnish..

bernardmaltais commented 3 years ago

I have added the examples for all the components I have been able to test against... I am pretty sure redis, postgresql already support them...

bernardmaltais commented 3 years ago

@zachomedia OK... finally got through all the linting issues. Change request completed ;-)

sylus commented 3 years ago

Thanks so much this looks good!