search

drupalwxt / helm-drupal

Helm Chart for deploying an enterprise-grade Drupal environment.
https://drupalwxt.github.io/helm-drupal/index.yaml
MIT License
31 stars 22 forks source link

Update ingress configs with ingressClassName #111

Closed markwooff closed 2 years ago

markwooff commented 2 years ago

The latest Kubernetes versions are removing the deprecated kubernetes.io/ingress.class annotation for selecting an Nginx ingress controller and are pushing to use the .spec.ingressClassName field (see: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#what-to-do). Adding this into the Ingress configs will allow a developer to set their Ingress class using the format below:

ingress:
  enabled: true
  className: my-nginx-class
markwooff commented 2 years ago

This looks good @markwooff! Thank you! Can you add a commented-out example of the value in values.yaml?

No problem! Just added one in and removed the deprecated kubernetes.io/ingress.class annotation.

sylus commented 2 years ago

Oh just one more thing can you bump the chart.yaml version as well?

markwooff commented 2 years ago

Chart versions have been bumped.