search

drupalwxt / helm-drupal

Helm Chart for deploying an enterprise-grade Drupal environment.
https://drupalwxt.github.io/helm-drupal/index.yaml
MIT License
31 stars 22 forks source link

Disable volume name #116

Closed bernardmaltais closed 2 years ago

bernardmaltais commented 2 years ago

This change prevent volumeName from being manually created by the chart. This will let the kubernetes cluster dynamically create PV based on the PVC configuration instead.

zachomedia commented 2 years ago

I agree with adding this to the chart, I want to take a deeper look at the logic to confirm to change - though at first glance it looks good.

bernardmaltais commented 2 years ago

@zachomedia Any chance this will be merged in the main branch. This is the last pull request that prevent me from using the main chart code instead of my own form.

zachomedia commented 2 years ago

@bernardmaltais Apologies for the delay, things were hectic leading up to my vacation last week. I will confirm this works in the next couple of days and then merge it :) At a first glance, I don't see any issues.