search

drupalwxt / helm-drupal

Helm Chart for deploying an enterprise-grade Drupal environment.
https://drupalwxt.github.io/helm-drupal/index.yaml
MIT License
31 stars 22 forks source link

Allow ability to suppress tar errors on file restore #132

Closed Stemirabo closed 2 years ago

Stemirabo commented 2 years ago

Since tar currently throws errors while restoring files when working with an azure file share, I've added in a way to suppress errors from the tar commands in the file restore step. By default this will change nothing, but we can activate this through Terraform.

This can be reverted once the core issue with TAR is resolved.

zachomedia commented 2 years ago

@Stemirabo Would you be able to also increase the version field in Chart.yaml on the charts? Once that's done, this should be good to go!

Stemirabo commented 2 years ago

@zachomedia Thanks for catching that. Versions incremented.

zachomedia commented 2 years ago

Thanks!

bernardmaltais commented 2 years ago

Interesting. We ran into the same issue but during the backup cronjob. Somehow one or more files are updated while tar is running, and this is causing it to return an exit 1 code that makes the backup job to restart can create another backup... very annoying.

So far, we have fixed it using a Kubernetes patch we apply post helm chart deployment.

I feel the whole backup and restore scripts should be moved out of the chart and put in the values file so users can substitue them with their own versions...