drupalwxt / helm-drupal

Helm Chart for deploying an enterprise-grade Drupal environment.
https://drupalwxt.github.io/helm-drupal/index.yaml
MIT License
31 stars 22 forks source link

Azure fileshare on Kubernetes 1.19 bug #56

Closed thomascraig closed 3 years ago

thomascraig commented 3 years ago

discovered a little bug when deploying to kubernetes 1.19 on AKS with Azure fileshare - in your values.yaml file lines 286 and 293 need to append the secretNamespace or it looks in the default namspace, existing code:

  `secretName: drupal-storage`
  `shareName: drupal-public`
  `readOnly: false`

fix is to include the secretNamespace attr:

 `secretName: drupal-storage`
 `secretNamespace: {active-ns}`
 `shareName: drupal-public`
 `readOnly: false`
sylus commented 3 years ago

I added this as an inline comment in https://github.com/drupalwxt/helm-drupal/issues/56

Does that work for you? I don't seem to experience this in Kubernetes 1.17 atm.

sylus commented 3 years ago

Thinking we good with P.R. :D please reopen if not

thomascraig commented 3 years ago

yes, comment works. thanks.