drupalwxt / wxt

Drupal 10 variant of the Web Experience Toolkit (WxT).
https://drupalwxt.github.io
GNU General Public License v2.0
25 stars 27 forks source link

Composer install #126

Closed rgalipeau closed 5 years ago

rgalipeau commented 5 years ago

Hey guys... if I run composer create-project drupalwxt/wxt-project:8.x-dev MYPROJECT --no-interaction I get Drupal WxT 8.5.6 ??

Also, I get a notice about react Package react/socket-client is abandoned, you should avoid using it. Use react/socket instead.

zachomedia commented 5 years ago

Updated wxt-project with https://github.com/drupalwxt/wxt-project/commit/7ed3b8fb7c0fde29241eb7fb6b238ddc394a49f4

(I haven't tested yet, but should be good now)

rgalipeau commented 5 years ago

This now works. Do you not use composer internally when doing builds? (just curious as to how we go to 8.6 without anyone else running into this? @zachomedia @sylus

P.S. DevDesktop 2 and php 7.1 tested also. (works great).

I'm closing Issue as it works, but curious how anyone was able to test/launch without composer @zachomedia change now pointing to 2.2.1 ?

zachomedia commented 5 years ago

We don't use wxt-project internally, we have a different project structure/scaffold system.

Also, once you've done the initial setup with composer create-project, it doesn't use wxt-project anymore. You would just update composer.json to point at the new WxT.

rgalipeau commented 5 years ago

Thanks Zach. Nice to see the buildout work. (Also had composer Mojave related issue locally which needed update on xcode), but got through it a few weeks ago.

I'll test a clean tarball with DevDesktop and see if that's all good next.