drupol / drupal-conventions

Check (and fix) your code against Drupal's code conventions and coding standard.
MIT License
24 stars 1 forks source link

Conflict between PhpCsFixer and Phpcs regarding multiline comments #3

Closed aritomelo closed 5 years ago

aritomelo commented 5 years ago

Steps required to reproduce the problem

  1. This multine comment is accepted by Phpcs and not PhpCsFixer
    /* Immediately render hidden elements before the rest of the output.
     * The uploadprogress extension requires that the hidden identifier input
     * element appears before the file input element. They must also be siblings
     * inside the same parent element.
     *
     * @see https://www.drupal.org/node/2155419
     */
  2. Instead PhpCsFixer prefer this:
    /** Immediately render hidden elements before the rest of the output.
     * The uploadprogress extension requires that the hidden identifier input
     * element appears before the file input element. They must also be siblings
     * inside the same parent element.
     *
     * @see https://www.drupal.org/node/2155419
     */
drupol commented 5 years ago

Fixed in https://github.com/drupol/phpcsfixer-configs-drupal/commit/764d0a72bcd371afca41defdcf0450cd98242fb5

Rebuilt and you should be good to go.