Failed installation on PHP 7.2

elgandoz commented 5 years ago

Steps required to reproduce the problem

composer require --dev drupol/drupal-conventions (on PHP 7.2)

Expected Result

drupal-convention being installed

Actual Result

Failed installation due PHP requirements

dev git:(feature/coding-standards) ✗ composer require --dev drupol/drupal-conventions
    1/1:    https://packages.drupal.org/8/drupal/provider-2019-3$66989b72080388aac59adf984ff58a43fff8b34df4edd9ec9330d290fc7a4d40.json
    Finished: success: 1, skipped: 0, failure: 0, total: 1
    1/7:    http://repo.packagist.org/p/provider-latest$43d8c32e3be0ff06e581c521a942e11a87eab383541c6e2ddc24c3f154cbb42a.json
    2/7:    http://repo.packagist.org/p/provider-2019-07$737a7d757d547e8a26cbd9ffee08bfa204797dd2249583270048c627047144e5.json
    3/7:    http://repo.packagist.org/p/provider-2014$6c1424310e5581b6c688425b0aa66350a27a1bf03aa1c73ac5cfd0bdd111759e.json
    4/7:    http://repo.packagist.org/p/provider-2016$34787e71e3b283b987afdd111430ba3d9a7ffcda0f0028773bc7d72526f2190c.json
    5/7:    http://repo.packagist.org/p/provider-2019-04$7897880d15e37023cd853170681b141b7d7d8b8655bca271255b3ed204be2919.json
    6/7:    http://repo.packagist.org/p/provider-2018$8dd381b4a978eeddfcd28e6d637b18bb02b19b702a011d868bd5c368ae2bbd04.json
    7/7:    http://repo.packagist.org/p/provider-2017$2c54c0f2ce2a7093720617daf8e91615b4981d6d223b499d4b43c15665d38519.json
    Finished: success: 7, skipped: 0, failure: 0, total: 7
Using version ^1.7 for drupol/drupal-conventions
./composer.json has been updated
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - drupol/drupal-conventions 1.7.1.1 requires php ^5.6 -> your PHP version (7.2.18) does not satisfy that requirement.
    - drupol/drupal-conventions 1.7.1.0-dev requires php ^5.6 -> your PHP version (7.2.18) does not satisfy that requirement.
    - drupol/php-conventions 1.5.8.1 requires php ^5.6 -> your PHP version (7.2.18) does not satisfy that requirement.
    - drupol/php-conventions 1.5.8.0-dev requires php ^5.6 -> your PHP version (7.2.18) does not satisfy that requirement.
    - drupol/drupal-conventions 1.7.1 requires drupol/php-conventions ^1.5.8 -> satisfiable by drupol/php-conventions[1.5.8, 1.5.8.0-dev, 1.5.8.1].
    - Installation request for drupol/drupal-conventions ^1.7 -> satisfiable by drupol/drupal-conventions[1.7.1, 1.7.1.0-dev, 1.7.1.1].
    - Conclusion: remove symfony/yaml v3.4.30
    - Conclusion: don't install symfony/yaml v3.4.30
    - drupol/php-conventions 1.5.8 requires symfony/yaml ^4.2 -> satisfiable by symfony/yaml[4.2.x-dev, 4.3.x-dev, 4.4.x-dev, v4.2.0, v4.2.0-BETA1, v4.2.0-BETA2, v4.2.0-RC1, v4.2.1, v4.2.10, v4.2.11, v4.2.2, v4.2.3, v4.2.4, v4.2.5, v4.2.6, v4.2.7, v4.2.8, v4.2.9, v4.3.0, v4.3.0-BETA1, v4.3.0-BETA2, v4.3.0-RC1, v4.3.1, v4.3.2, v4.3.3].
    - Can only install one of: symfony/yaml[4.2.x-dev, v3.4.30].
    - Can only install one of: symfony/yaml[4.3.x-dev, v3.4.30].
    - Can only install one of: symfony/yaml[4.4.x-dev, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.0, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.0-BETA1, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.0-BETA2, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.0-RC1, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.1, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.10, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.11, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.2, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.3, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.4, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.5, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.6, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.7, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.8, v3.4.30].
    - Can only install one of: symfony/yaml[v4.2.9, v3.4.30].
    - Can only install one of: symfony/yaml[v4.3.0, v3.4.30].
    - Can only install one of: symfony/yaml[v4.3.0-BETA1, v3.4.30].
    - Can only install one of: symfony/yaml[v4.3.0-BETA2, v3.4.30].
    - Can only install one of: symfony/yaml[v4.3.0-RC1, v3.4.30].
    - Can only install one of: symfony/yaml[v4.3.1, v3.4.30].
    - Can only install one of: symfony/yaml[v4.3.2, v3.4.30].
    - Can only install one of: symfony/yaml[v4.3.3, v3.4.30].
    - Installation request for symfony/yaml (locked at v3.4.30) -> satisfiable by symfony/yaml[v3.4.30].

Installation failed, reverting ./composer.json to its original content.
➜  dev git:(feature/coding-standards) ✗

drupol commented 5 years ago

Interesting, I will update tonight!

Thanks

drupol commented 5 years ago

I just tried locally with PHP 7.2 and I was not able to reproduce the issue.

Log: https://pastebin.com/uJMwmAji

drupol commented 5 years ago

Can you try to:

remove the .lock files from
remove the vendor directory
run: composer require --dev drupol/drupal-conventions

drupol commented 5 years ago

Based on your log, I've updated both patckages, this one and the sub-package drupol/php-conventions and relaxed the dependency on symfony/yaml to allow the use of version ^3.4.

I tagged the version 1.7.2, let me know how it goes :-)

elgandoz commented 5 years ago

After clearing composer cache, installation went trough perfectly. Thanks for your quick fix. I'll close this issue

drupol commented 5 years ago

Great !

drupol / drupal-conventions