search

drupol / drupal-conventions

Check (and fix) your code against Drupal's code conventions and coding standard.
MIT License
24 stars 1 forks source link

Class drupol\PhpConventions\Grumphp\Task\ComposerNormalize does not exist #6

Closed elgandoz closed 5 years ago

elgandoz commented 5 years ago

Steps required to reproduce the problem

  1. composer create-project drupal-composer/drupal-project:8.x-dev testground --no-interaction
  2. cd testground/ && composer require --dev drupol/drupal-conventions
  3. vi composer.json, adding extra grumphp config
  4. git init && git add . && git commit -m "first commit"

Expected Result

Actual Result

elgandoz commented 5 years ago

This issue first happened to me while working on an existing project, with drupal-convention successfully working. In a big merge with several conflicts, I opted to remove vendor/ and composer.lock and install everything again: that's when I experienced the issue. Later I built a vanilla drupal installation few times, with the same issue.

The class drupol\PhpConventions\Grumphp\Task\ComposerNormalize doesn't exist indeed, and it's related with changes done in https://github.com/drupol/php-conventions/commit/6e3c7a98375c109402c4847bba57199e9b028147.

Commenting services.task.composer_normalizein the referenced grumphp.yml allows the tasks to be performed (and apparently working, given it detects wrong indentation in the project's composer.json and any other coding standard issues)

drupol commented 5 years ago

Yes, thanks for noticing it, I just fixed it.

New tag 1.7.3 is available now.

drupol commented 5 years ago

Hi,

Have you updated to 1.7.3 ?