Fix all the whitespace style errors

[drusepth]

Can we just jshint (or ruby-equivalent) the whole system and fix everything? Whitespace seems like a good place to start. Not a big deal, but pretty code is pretty code.

• [ ] Fix whitespace-at-end-of-line errors
• [ ] Normalize all tabs to spaces (and otherwise conform to github style guidelines)

[Cantido]

Yeah absolutely. ActiveModel actually includes a set of Lint tests that we can include. I'll do some research and stick a few references here. Also there's ruby-lint and Rubocop. I think I'd like to look at using what's built into ActiveModel, then make the most of Rubocop. Then we could consider ruby-lint but I think Rubocop is more widely used.

Also, I'm on vacation all through this coming week, and I can think of nothing I'd enjoy more than to sit and code something fun like this.

• http://yehudakatz.com/2010/01/10/activemodel-make-any-ruby-object-feel-like-activerecord/
• http://api.rubyonrails.org/classes/ActiveModel/Lint/Tests.html
• https://github.com/bbatsov/rubocop (More focused on coding style)
• https://github.com/YorickPeterse/ruby-lint (More focused on technical issues)

[drusepth]

Excellent! A lot of people complain lint is a bit too strict sometimes, but I think it'd be good to set up at least and decide whether it's too strict and standardize with some solution accordingly. :dancers:

[Cantido]

The recommendation I've heard is to start out very basic, like just enforce ending whitespace. Then you clean up all of those errors, and then work your way up to more strict rules. I think it's called ratcheting.

[Cantido]

I found reek which is a "code smell detector" for Ruby. I like the sound of it. I'll do some more research and see if it's something we should add. This code is going to be a work of art.