search

drusepth / Indent

Indent is a set of tools for writers, game designers, and roleplayers to create magnificent universes – and everything within them.
http://indentapp.com
1 stars 1 forks source link

Internationalize strings #433

Closed Cantido closed 9 years ago

Cantido commented 9 years ago

This will close #362

drusepth commented 9 years ago

Do the views also need to be changed to use these strings also?

Cantido commented 9 years ago

Yep. Check out the rails-i18n gem, those files have some structures we ought to use, like "Create %{model}". I assume the way to use those is the "correct" way to do some things.

On Wed, Apr 22, 2015, 1:28 AM Andrew Brown notifications@github.com wrote:

Do the views also need to be changed to use these strings also?

— Reply to this email directly or view it on GitHub https://github.com/drusepth/Indent/pull/433#issuecomment-95045860.

Cantido commented 9 years ago

Phew! That's all of the views in app/views/main and app/views/layouts done. I did leave out _future_navbar.html.erb, since I imagine you still need to create models for it, which would allow us to use Model.model_name.human.

drusepth commented 9 years ago

The code is looking so much better than it did just a couple months ago. Thanks a ton for all of this.

Cantido commented 9 years ago

My pleasure! There is still work to be done but the structure is there. I just got burned out on the model pages lol. At least the main pages are done.

On Tue, Apr 28, 2015, 11:04 PM Andrew Brown notifications@github.com wrote:

Merged #433 https://github.com/drusepth/Indent/pull/433.

— Reply to this email directly or view it on GitHub https://github.com/drusepth/Indent/pull/433#event-292651520.

drusepth commented 9 years ago

@Cantido Oh oops, I merged and then saw your comment about _future_navbar.html.erb. Is there more work here you wanted to do outside of that? (AKA did I merge too soon?)

Cantido commented 9 years ago

I was expecting to completely internationalize the site before merging, and most of the model views haven't been touched yet. However, I've done all the other work necessary, like setting the users locale from the http headers and setting a default locale. All that's left is the slow work of extracting strings.

On Tue, Apr 28, 2015, 11:05 PM Andrew Brown notifications@github.com wrote:

@Cantido https://github.com/Cantido Oh oops, I merged and then saw your comment about _future_navbar.html.erb. Is there more work here you wanted to do outside of that? (AKA did I merge too soon?)

— Reply to this email directly or view it on GitHub https://github.com/drusepth/Indent/pull/433#issuecomment-97298489.

drusepth commented 9 years ago

@Cantido I went ahead and reverted the merge and restored the start-i18n branch. Feel free to open another pull request whenever is convenient and we'll push all the internationalization changes through together. :+1: