drustanyjt / pe

0 stars 0 forks source link

Overzealous Restriction To Phone Number #8

Open drustanyjt opened 5 months ago

drustanyjt commented 5 months ago

Feature Flaw Description

As per PE guide:

image.png

However currently phone numbers are restricted to a single string of digits.

Steps To Illustrate Example

  1. Type edit 1 p/1234 5678 (HP) 1111-3333 (Office)
  2. Error is shown:

image.png

Severity

severity.Low : A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.

Not a purely cosmetic issue in docs or UI, so cannot be VeryLow. While it is not rare to have multiple phone numbers, there is a work around (adding numbers as tags). Hence I gave it Low.

soc-se-bot commented 5 months ago

Team's Response

Hi thank you for your report,

While a student may have multiple phone numbers, it is highly unlikely for a student to have an office number. Additionally, for a TA, only one number would be necessary for them to carry out their tasks in the rare chance they need to contact a student by their phone number.

However, we see that is could maybe be a good to have, but not necessary, that could be implemented in the future. As the UG specifies that this behaviour exists, and there is proper handling of the error message, we believe that this is not in scope

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]