search

drvinceknight / rsd

Repository for a two day workshop on research software development aimed at mathematicians
MIT License
0 stars 20 forks source link

Add Sophie to list of participants #148

Closed shapperzsm closed 5 years ago

shapperzsm commented 5 years ago

Purpose of PR: To become familiar with version control, git and GitHub so I can use it for my final year (year 4) project.

I have attempted to follow the instructions as highlighted on 'https://vknight.org/rsd/chapters/06/' but I would be very grateful if you would be able to highlight if I have made a mistake at all. Only if you have time though as I appreciate you must be very busy. Thank you very much for this course, I have found it very interesting and extremely useful.

Nikoleta-v3 commented 5 years ago

Hey @shapperzsm! The 'PR' is really good, and your commit message as well! 🎉

As you can see there is a little x next to your commit. That indicates a failure but it has nothing to do with anything you changed, this is actually something we need to fix!

So I am going to go ahead a merge your PR. Once again very well done on your first pull request 😄

shapperzsm commented 5 years ago

Thanks very much @Nikoleta-v3 for the feedback 👍