minor fixes to the writing.

drvinceknight / testing_for_ZD

Recognising zero determinant strategies: code for a paper under review (pre print: https://arxiv.org/abs/1904.00973).

MIT License

1 stars 1 forks source link

minor fixes to the writing. #50

Closed Nikoleta-v3 closed 6 years ago

Nikoleta-v3 commented 6 years ago

I have a few comments on the plots but will comment them on the pr.

Also will need to rebase after #49 is merged.

Nikoleta-v3 commented 6 years ago

Regards the plots:

Figure 1. Some x-labels are missing
Figure 4. Only 3/4 states are plotted, not sure if it was done on purpose.
Figure 4. Caption not completed. Add a sentence for the state plots?
Figure 5. Labels' size.

If I have time I will fix these!

Nikoleta-v3 commented 6 years ago

I don't have strong a feeling about but: https://github.com/drvinceknight/testing_for_ZD/blob/bad75119c6adfb9ff2fa5c5ea5edd48d9dd624cb/main.tex#L316

$P$ is also used for payoff notation.

drvinceknight commented 6 years ago

$P$ is also used for payoff notation.

Good point! Also, the wording of that sentence is wrong: it's a transition rate matrix, I'll reword this and find a different symbol than $P$.

drvinceknight commented 6 years ago

Only 3/4 states are plotted, not sure if it was done on purpose.

The missing state is actually captured in the $P(CD)$ plot: $P(DC)$ would just be the same but flipping the diagonal. All your other points are valid though: I'll open an issue and tweak :) :+1:

drvinceknight commented 6 years ago

Thanks for the modifications: they all look great :+1: