search

drweb86 / Gherkin-Beautifier-VS-Code-Plugin

Gherkin Beautifier VS-Code Plugin
MIT License
0 stars 0 forks source link

Incorrect table autoformat with comments #22

Closed k03mad closed 3 years ago

k03mad commented 3 years ago

Hello,

Is there a way to support comments in the tables? Example table:

    Scenario Outline: test
        Given "<PAGE>" opened
        Then I enter the "<TEXT>"

        Examples:
            | PAGE        | TEXT           |
            # some comment about this example
            | /search?a=b | hello          |
            # next comment about current example
            | /query      | test test test |

Autoformat removes table indents:

    Scenario Outline: test
        Given "<PAGE>" opened
        Then I enter the "<TEXT>"

        Examples:
            | PAGE | TEXT |
            # some comment about example
            | /search?a=b | hello |
            # another comment about next example
            | /query | test test test |
drweb86 commented 3 years ago

Hi, Kirill,

Consider adding a New column to a table called Comments or Description and put there your comment as table cell. Will it solve issue you are facing with?

Let me know if this works for you

пн, 21 июн. 2021 г., 14:04 Kirill Molchanov @.***>:

Hello,

Is there a way to support comments in the tables? Example table:

Scenario Outline: test
    Given "<PAGE>" opened
    Then I enter the "<TEXT>"

    Examples:
        | PAGE        | TEXT           |
        # some comment about this example
        | /search?a=b | hello          |
        # next comment about current example
        | /query      | test test test |

Autoformat removes table indents:

Scenario Outline: test
    Given "<PAGE>" opened
    Then I enter the "<TEXT>"

    Examples:
        | PAGE | TEXT |
        # some comment about example
        | /search?a=b | hello |
        # another comment about next example
        | /query | test test test |

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/drweb86/Gherkin-Beautifier-VS-Code-Plugin/issues/22, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABD6N3P2ZQI4XOUBPTA3MEDTT4MEZANCNFSM47BLFEIA .

k03mad commented 3 years ago

Yep, it certainly work as a separate column

Сomments between lines are most likely a very rare case Just thought that this could be supported :)

drweb86 commented 3 years ago

Nice, i've checked cucumberjs parser and found that they are supported for tables there too. But i really have not much time to rewrite plugin using their parser or change my table recognizer. So lets close it until there will be more ppl facing same issue.

пн, 21 июн. 2021 г., 15:16 Kirill Molchanov @.***>:

Yep, it certainly work as a separate column

Сomments between lines are most likely a very rare case Just thought that this could be supported :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/drweb86/Gherkin-Beautifier-VS-Code-Plugin/issues/22#issuecomment-864986170, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABD6N3MTSP3ZPVZOF4TI4KTTT4US3ANCNFSM47BLFEIA .