search

drweissbrot / cs-hud

Custom Counter-Strike Spectator HUD
ISC License
230 stars 39 forks source link

Map win panel requires team names to match exactly #117

Open vladxy opened 8 months ago

vladxy commented 8 months ago

When I use the bo3 setup, after the 1st map is set and the score is submitted, it shows on the HUD that the score is 1-1 instead of 1-0

drweissbrot commented 8 months ago

I'm not entirely sure what the situation is here. Could you post a screenshot of the Series: Map 1 to Series: Map 5 sections on the config page, or the theme.json from your cs-hud/userspace directory?

vladxy commented 8 months ago

pEORTV7 Those were the setting for Map 1 through 3, map 4 and 5 were left completely blank. With these scores, it showed as 1-1 on the hud under the timer. Should I post the theme.json as well?

vladxy commented 8 months ago

Also kind of in the same field, when the match is setup as a bo1 and the checkmark for decider is not set, it shows the match as being a bo2, first map is showing up correctly but it also shows a blank "decider", and under the timer it reads "map 1 out of 2"

vladxy commented 8 months ago

pEORTV7 Those were the setting for Map 1 through 3, map 4 and 5 were left completely blank. With these scores, it showed as 1-1 on the hud under the timer. Should I post the theme.json as well?

Also want to add to this one, the score was not submitted to the second map when I encountered the error, when it was submitted like in this screenshot, it showed the score under the timer as "2-2"

drweissbrot commented 8 months ago

Interesting, I had a look at it with the demo (https://www.hltv.org/matches/2368847/9ine-vs-koi-pgl-cs2-major-copenhagen-2024-europe-rmr-open-qualifier-1) and the data from your screenshot, and it looks like the HUD's getting confused because the team names don't match exactly. The HUD thinks a team called 9INE lost map 2, so when it finds a team that's not called 9INE, it'll consider them a winner of that match -- but neither team is called 9INE (because they're actually called 9INEgg on the server), so it just gives them both a win.

I'm not immediately sure if it's possible to work around that in software, will think about it. Thanks for reporting!

Workaround for now: You can either just type 9INEgg in series.maps.2.pickTeam, or you could rename 9INEgg to 9INE, cf. https://github.com/drweissbrot/cs-hud/blob/c8f8a93574fe74eb756e46a2d7f6f16a692d4559/docs/team-name-overrides.md.

vladxy commented 8 months ago

Will try in the bo3 and I'll get back to you

vladxy commented 8 months ago

So indeed that was the issue, it works if the names are exactly the same as the ones on the server, but the bo1 thing still doesn't work properly I think

drweissbrot commented 8 months ago

Also kind of in the same field, when the match is setup as a bo1 and the checkmark for decider is not set, it shows the match as being a bo2, first map is showing up correctly but it also shows a blank "decider", and under the timer it reads "map 1 out of 2"

Could you make sure that the decider checkbox is not set for any map? If it's checked for map 3 for example, that'll cause that phantom map to show up.

vladxy commented 8 months ago

I redid the settings as for a bo1, only thing I put in was the map name for the 1st map, nothing else on any of them. With those settings, if it's supposed to show the map that is being played, nothing is showing.

drweissbrot commented 8 months ago

Correct, it's not supposed to show the "Map 1 of 1" bit below the clock, nor the map name on the bottom during freezetimes for a BO1.
If you really want it, you can force it to show the current map during freezetimes by checking the preferences.seriesGraph.showMapForOnlyMatch checkbox.

vladxy commented 8 months ago

Okay, thanks for the help, so far the HUD as been awesome, great job!