Closed ryanleaf1000 closed 10 months ago
I don't see how that could happen - when I run make indent
after deleting the whitespace changes they do not come back.
Thanks David. I followed your instruction and make indent works this time!
Hello David, I just added two tests to the PR. Another thing I think is worth discussing is. Do we want to return the intersection points in element reference coordinates as what we did in IBAMR? because in order to do "force spreading", we would need to access the value of FE solution at the intersection point. Any suggestions for next step?
I'm not sure if reference or physical coordinates are better here. Since we have simplices they are only an affine transformation away from each-other: it is easy to go back-and-forth.
Tests need to have input and output files. Can you sort that out? Take a look at some of the other tests to see what the test runner expects.
Hello David, I just added the input files. Please let me know what you think or next steps!
Hello David, is it look better now?
Ok I think the output file should be fine now
Hello David, I removed two space. Can you check again? actually are there anyway I can do this check myself?
Thanks. Can you squash your commits?
Done. Is this looks better?
This has everything so lets merge! Thanks!
Hello David, I just update a new version. Is this look better? Please ignore the incorrect reference. I would fix it after we agree with the intersection function. I haven't tried to compile it as we still may want major change to it. Also is the format looks better? I run the clang-format to these two file, it seems automatically add those space. Do you know why?