drwetter / testssl.sh

Testing TLS/SSL encryption anywhere on any port
https://testssl.sh
GNU General Public License v2.0
7.98k stars 1.03k forks source link

Missing 'hexdump' causes errors #1146

Closed firewave closed 6 years ago

firewave commented 6 years ago
 rDNS (127.0.0.1):       localhost.
./testssl.sh: line 12208: hexdump: command not found

Maybe it should check for the existence or have a fallback.. It happened with the minimal installation of either CentOS 7 or ubuntu 16.04.

I was using 3.0rc1.

FYI the command to get the version from as suggested in the template no longer works.

./testssl.sh -b 2>/dev/null | head -4 | tail -2

###########################################################
drwetter commented 6 years ago

For hexdump: well, normally the message should be self-explanatory. I made it more beautiful, see next commit.

For the template: works for me. Did that occur after you installed hexdump?

firewave commented 6 years ago

For hexdump: well, normally the message should be self-explanatory. I made it more beautiful, see next commit.

Thanks - in case of automated usage it is just better to have proper message instead of inline failure. I haven't even checked if the inline failures actually affected the exit code.

FYI the system in question was ubuntu.

For the template: works for me. Did that occur after you installed hexdump?

Yes, after install hexdump it was working.

drwetter commented 6 years ago

Thanks!

chrisdlangton commented 4 years ago

On debian buster, clean install, getting this error

Fatal error: You need to install hexdump for this program to work

Tried installing the apt xxd package, the perl hexdump and hexdumper libs, and even resorted to the hexdumper lib from pip! All no joy

What is the testssl dependency exactly and how does one make testssl work on one of the top 3 distros?

chrisdlangton commented 4 years ago

hours of searching, trying alternative distros (but encountered other issues with other libs), I finally came across bsdmainutils that provides hexdump. Note for those using debian slim containers, you'll also need to install procps

drwetter commented 4 years ago

hours of searching

Chris, when I google for hexdump and debian bsdmainutils is the first hit. Hexdump was preinstalled on my last buster system a while back when it was fresh. Maybe that changed.

Note for those using debian slim containers, you'll also need to install procps

Thanks but I sense here also the problem here is sitting in front of the computer ¯_(ツ)_/¯

chrisdlangton commented 4 years ago

what a helpful post to share with your community, you're really showing off the extent of your usefulness to the community with that post! What's your problem with debian slim anyway? do you like bloated OCI running in prod and avoid clean images?

As for the google remark, if I even used google there's no way the first result would have the same bias as your results, bsdmainutils was several pages into my search engine results and I skipped it on the first pass based on the name alone which gives no helpful hints when looking for hexdump.

drwetter commented 4 years ago

Look, this project contains multiple man-months of development by David and me. The result is for free. Nobody's paying me for it and I'd rather continue to spend time on continuing development.

This should be a fair deal also for you.

Screenshot_20200302_091446 Screenshot_20200302_091534