drwhut / tabletop-club

An open-source platform for playing tabletop games in a physics-based 3D environment for Windows, macOS, and Linux! Made with the Godot Engine.
https://tabletopclub.net
MIT License
1.3k stars 57 forks source link

Bug: Preview Feature inconsistent #183

Closed elmodor closed 1 year ago

elmodor commented 1 year ago

Describe the bug Follow up of #178

The hand preview feature is inconsistent. Currently the preview is enabled for cards in your own hand which are NOT selected. Why is the preview disabled for selected cards?

Is it to avoid that the preview is shown too often?

I think the preview popup is:

In my opinion, a good preview would be:

To Reproduce Steps to reproduce the behavior:

  1. Spawn card
  2. Move card to hand
  3. Preview does not pop up
  4. Click on table to deselect
  5. Preview does pop up

Expected behavior See above

Version v0.1.0 Beta 1

drwhut commented 1 year ago

I agree, this could be improved. However, this is dangerously close to #114 - I think it may be worth merging this into that issue, and mention the selected/unselected thing there. The keybind idea has already been mentioned there.