search

drwhut / tabletop-club

An open-source platform for playing tabletop games in a physics-based 3D environment for Windows, macOS, and Linux! Made with the Godot Engine.
https://tabletopclub.net
MIT License
1.3k stars 57 forks source link

Customize the room code #224

Closed GrimPixel closed 1 year ago

GrimPixel commented 1 year ago

Is your feature request related to a problem? Please describe. Currently, it is composed by four Latin letters, allowing 456976 rooms, which may cause problems like Pokémon Sword and Shield.

Describe the solution you'd like Be able to customise the room code.

drwhut commented 1 year ago

which may cause problems like Pokémon Sword and Shield.

Can you elaborate on this?

elmodor commented 1 year ago

I think increasing the room code to like 8 or maybe more digits should also be sufficient for now.

On Fri, 6 Jan 2023, 09:25 drwhut, @.***> wrote:

which may cause problems like Pokémon Sword and Shield.

Can you elaborate on this?

— Reply to this email directly, view it on GitHub https://github.com/drwhut/tabletop-club/issues/224#issuecomment-1373340141, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR3J4WSMMBPJQ3IGWZGN33WQ7JGTANCNFSM6AAAAAATSRWTLM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

drwhut commented 1 year ago

I'm not sure if increasing the number of characters is necessary - there will probably never be a time where there is more than 400,000 rooms active at once, I'd even be surprised if 50 rooms is surpassed to be honest.

Plus, we also want to keep the room code as simple and as memorable as possible so it's not a hastle for people to join a room.

GrimPixel commented 1 year ago

Pokémon Swords and Shields used to have 4 digits for a room, so a lot of people sent their pokémon to the wrong people. Later it was changed to 8 digits.

Custom names are memorable. It is how Jitsi Meet does.

You can be confident on its popularity. It is the only open-source tabletop game, written in GDScript, so the open-source community will be glad to know it; it can be used for education as well, so teachers and parents will find its value as well; it doesn't need much system resources; once the IME is supported, it will be known in East Asia; Digital India has been going on, which also stimulates the digitalisation in other developing countries, bringing more players.

drwhut commented 1 year ago

Will close this issue for now, I'm still not convinced that the room codes need to go beyond 4 characters (but thank you for the kind words anyways, Grim!) - if problems start arising from the lack of characters, I can always up the amount in the following update.