search

drwhut / tabletop-club

An open-source platform for playing tabletop games in a physics-based 3D environment for Windows, macOS, and Linux! Made with the Godot Engine.
MIT License
1.25k stars 50 forks source link

Slower image loading than before #267

Closed GrimPixel closed 1 year ago

GrimPixel commented 1 year ago

Comparing to Beta 3, images are loaded slower. This increases the chance of freezing when flipping object pages quickly.

drwhut commented 1 year ago

This will be due to the workaround in dcb084d9b281cf6412d6a7775a0ff1ef2da3b852, but after some further testing, the workaround doesn't seem to work 100% of the time... I'm getting freezing in both Beta 4 and RC 1, I think I might have gotten lucky when testing the fix when it was first implemented.

I might end up removing the workaround if it doesn't help with the freezing that much since it leads to longer loading times, like you said in this issue and in #265.

drwhut commented 1 year ago

After some further testing both with and without the workaround, it looks like the game lasts on average twice as long before freezing with the workaround included. So I've decided to keep it in for now even if it doesn't fully fix the freezing. v0.2.0 will have a revamped objects menu which should remove the root issue altogether.