search

drwhut / tabletop-club

An open-source platform for playing tabletop games in a physics-based 3D environment for Windows, macOS, and Linux! Made with the Godot Engine.
MIT License
1.24k stars 49 forks source link

Separate the speaker function from the timer #271

Closed GrimPixel closed 1 year ago

GrimPixel commented 1 year ago

Is your feature request related to a problem? Please describe. Timers are not bound to be able to play music. I think the object “Radio” can be placed in “Speaker”, and use https://opengameart.org/content/alarm-clock for the “Timer”.

drwhut commented 1 year ago

Timers are a subclass of Speakers because they also have the ability to play sounds, particularly when the countdown reaches 0. One does not necessarily need to use the "Speaker" menu when interacting with a Timer, it's just there so if you want a track to start playing when the timer reaches 0, then you can do so.

On the alarm clock you linked, I actually tried to include that model when I first implemented timers, but I could not get it to work at all. I think the Blender file was too out-of-date, so I gave up and looked for other models.

GrimPixel commented 1 year ago

I think it could be “Speaker and Timer” then, since Timers are more useful. The phonograph can also be a timer with modifications today.

drwhut commented 1 year ago

Potentially, I'll consider that for v0.2.0