drwhut / tabletop-club

An open-source platform for playing tabletop games in a physics-based 3D environment for Windows, macOS, and Linux! Made with the Godot Engine.
MIT License
1.24k stars 49 forks source link

Use “cuboids”, “cylinders”, “figures” instead of “cards”, “tokens”, “pieces” #303

Closed GrimPixel closed 10 months ago

GrimPixel commented 10 months ago

Is your feature request related to a problem? Please describe. The “cards”-“tokens”-“pieces” solution is about the usage. With “cards”-“tokens”-“pieces”, there are confusions: tiles and tokens are both “tokens”, round cards and round pieces are “tokens”.

Describe the solution you'd like Use the “cuboids”-“cylinders”-“figures” solution, which is about physical shapes and makes no confusion on their usages.

drwhut commented 10 months ago

I'm not 100% sure on this, to be honest. I feel like this would make finding particular objects a lot harder for players just starting with the game. I imagine a lot of players who want to find, for example, a particular card, would more than likely be expecting to see a "cards" section in the objects menu, rather than a "cuboids" section. I understand your reasoning, but I think making the names of the sections more generic would actually cause more confusion in the long run, even if the section names are more "defined".

Plus, the way the game builds cards vs cube tokens is fundamentally different - cards have two separate textures, and are always flat, whereas cube tokens use just one texture, and their height can be adjusted. Therefore, "cuboids" cannot contain both cards and cube tokens, they have to be two separate types.

If anything, the instances you described of potential confusion can be solved via the UI - in fact, there is already an issue for renaming "Tokens" to "Tiles and Tokens" in #252. In the future, more folders could be scanned in asset packs to distinguish pieces from figures, as an example.

GrimPixel commented 10 months ago

Maybe instead of tokens/cylinder and token/cube, simply cylinders and cubes. That “dice” number of faces can be defined in config.cfg as well. Then there is no need for subdirectories.

drwhut commented 9 months ago

Maybe - if we decide that a compatibility break is necessary at some point, I'll consider those changes, but for now I want to try and keep asset packs working across various versions.