drwhut / tabletop-club

An open-source platform for playing tabletop games in a physics-based 3D environment for Windows, macOS, and Linux! Made with the Godot Engine.
https://tabletopclub.net
MIT License
1.28k stars 55 forks source link

Add a way to stop pre-made games from overwriting the current skybox. #304

Open GrimPixel opened 1 year ago

GrimPixel commented 1 year ago

Is your feature request related to a problem? Please describe. If players want to start a game, they don't necessarily want to change the 360-degree background image. Maybe also the table.

Describe the solution you'd like The 360-degree background is not stored for “Games.”

drwhut commented 1 year ago

Apologies for the late reply!

I could see this going both ways, to be honest. I can imagine some situations as you described where players don't necessarily want to use the skybox that was in use at the time of the save file being created, but on the other hand, I could also see some skyboxes fitting really well with the theme of certain games (e.g. a Werewolf game having a night-time/town skybox).

One thing I was considering adding in the v0.2.0 update is an additional pop-up dialog when the player is about to load a pre-made game, giving extra details about the game and more room for the description text box so that creators can put more of the rules or setup instructions in the config file. As part of this new dialog box, there could be a checkbox that, if enabled, would set the skybox to the one in the save file. That would give players the ability to choose whether they want to keep the current skybox or not, and it could be expanded upon later to include additional options or tweaks.

Another potential solution is to add a property to the config file for skyboxes, e.g. force_skybox, or something along those lines, that would tell the game if it should force the current skybox to be overwritten or not.

Either way, I think it makes sense to give players or creators the choice here since I can see both cases being wanted just as much as each other.

GrimPixel commented 1 year ago

I would like to leave the choice of whether a game should change its background to players, and let the asset creator decide if the option is enabled by default. Considering the table, radios / megaphones, there could be more options.