Fix gamut clipping - Githubissues

drwpow / better-color-tools

Better color tools for JS, TS, and Sass. Supports Oklab and CSS Color Module 4.

https://better-color-tools.pages.dev/

MIT License

78 stars 7 forks source link

Fix gamut clipping #19

Closed Piezoid closed 2 years ago

Piezoid commented 2 years ago

Changes

Hi ! Thanks for that new implementation of gamut clipping. However, I've noticed that lighten('red', 0.99) returns a pure red color.

After comparing Björn's implementation with yours, I found two errors:

In findCusp the luminance is only taking the blue channel into account because of extraneous parenthesis. This caused findGamutIntersection to work in the lower half instead of the upper half of the gamut.
The Halley's iteration in findGamutIntersection was returning the correction without adding it to the initial guess.

Checklist

[x] Changeset added (pnpm run changeset)
[x] Clear description of changes in PR notes and changeset
[x] I’ve added a test where I can (I haven't really checked that the regression test results make more sense than the original)

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 2dde7ca9504e7a4e17c63a6a1b2294eab8df53c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------------------ | ----- | | better-color-tools | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

drwpow commented 2 years ago

This has been published as v0.8.1! 🎉