dry-dock / u14

Ubuntu 14.04 base image
MIT License
1 stars 26 forks source link

Fixed PATH expansion #200

Closed prokopst closed 6 years ago

prokopst commented 6 years ago

Commit https://github.com/dry-dock/u14/commit/3d1c2515493d1491ff732773fde28ab0b7e6e4e4 introduced an unexpected behavior of $PATH.

Normally $PATH can be expanded this way:

$ docker run --rm -it ubuntu:16.04
$ root@aa190d3433ca:/# PATH="$PATH:/test" bash -c 'echo $PATH'
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/test

The change above introduced an unexpected behavior (notice missing :/test at the end):

$ docker run --rm -it drydock/u16
$ root@d248ceeef5de:/# PATH="$PATH:/test" bash -c 'echo $PATH'
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/lib/jvm/java-11-oraclejdk-amd64/bin

The consequence is that basically if anything adds something to $PATH the change is not propagated to any script calls, causing erroneous and very unexpected behavior. We noticed it when bats stopped working with the latest version of your images.