search

dry-rb / dry-cli

General purpose Command Line Interface (CLI) framework for Ruby
https://dry-rb.org/gems/dry-cli
MIT License
327 stars 41 forks source link

Fix ruby 2.7 keyword args warning #97

Closed timriley closed 4 years ago

timriley commented 4 years ago

Before this change, any CLI users would see a warning like this every time a command was invoked:

/Users/tim/Source/hanami/cli/lib/hanami/cli.rb:59: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/tim/Source/my-app/lib/hanami/cli/application/commands/db/version.rb:17: warning: The called method `call' is defined here

For a CLI tool, having this extra output noise is really undesirable.

I know we'll eventually be moving hanami/hanami to use dry-cli under the hood, but this fix here in the meantime will help anyone currently using the hanami unstable branches.

timriley commented 4 years ago

@jodosha FYI, since this fix has already been made inside dry-cli (see https://github.com/dry-rb/dry-cli/blob/767bfaea7aa663756f6a244a89fc3d244fe12f1c/lib/dry/cli.rb#L114), I'm just going to merge this straight in.