search

dry-rb / dry-container

A simple, configurable object container implemented in Ruby
https://dry-rb.org/gems/dry-container
MIT License
335 stars 41 forks source link

Use .new instead of inheritance to create Error class #35

Closed raventid closed 7 years ago

raventid commented 7 years ago

I've just noticed that Error class in container used inheritance, instead of Class.new -> https://github.com/dry-rb/dry-system/blob/master/lib/dry/system/errors.rb#L7

I think it would be nice to be consistent and to follow one rule. In my opinion - Class.new is preferable way.

AMHOL commented 7 years ago

Thanks :+1: