search

dry-rb / dry-container

A simple, configurable object container implemented in Ruby
https://dry-rb.org/gems/dry-container
MIT License
335 stars 41 forks source link

Fix incorrect version listed in docs #75

Closed bkuhlmann closed 3 years ago

bkuhlmann commented 3 years ago

Describe the bug

Noticed, when trying to install Dry Container 0.8.0, that it doesn't exist. Only 0.7.2 is the latest version at the time of this writing. By the way, this seems to be an oddity with other Dry libraries in case it's of interest. It seems the generated documentation is ahead of what is available.

To Reproduce

Visit the landing page (also notice 0.8 is in the URL as well). Here's a screenshot for illustration:

Firefox-ps0t0imc

Expected behavior

Would expect 0.7.2 to be listed instead of 0.8.0 as found on RubyGems.

My environment

Using Firefox as my browser.

solnic commented 3 years ago

Thanks for reporting this. It should be fixed now.

By the way, this seems to be an oddity with other Dry libraries in case it's of interest.

Which ones?

bkuhlmann commented 3 years ago

:bow: Piotr. Yeah, so here's what I found (well, in reverse of what I was reporting above, I guess):

solnic commented 3 years ago

@bkuhlmann thanks, it's unfortunate :( I haven't automated creation of new release branches and that's how we ended up with this. I'll create missing branches, thanks for preparing this list, very helpful!

flash-gordon commented 3 years ago

@solnic I think the bigger problem it's not documented, e.g. I don't remember what should be done to cut a doc release.

solnic commented 3 years ago

@flash-gordon a new tag == a new docsite, doesn't matter if things changed or not. Then every push to docsite in a release branch will result in docsite deployment on dry-rb.org

flash-gordon commented 3 years ago

@solnic what is "docsite"? :(

solnic commented 3 years ago

@flash-gordon directory in a repo 🙂

flash-gordon commented 3 years ago

@solnic I cannot decode "a new tag == a new docsite" then. A new directory?

solnic commented 3 years ago

@flash-gordon oh sorry for the confusion. I meant that every new major or minor tag must result in a corresponding release-x.y branch that must include the docsite dir. This part is not automated that's why we ended up with inconsistencies.

flash-gordon commented 3 years ago

@solnic I have such a branch https://github.com/dry-rb/dry-monads/tree/release-1.4 but there's no 1.4 in the docs https://dry-rb.org/gems/dry-monads/1.3/ Do you what I missed?