Closed solnic closed 2 years ago
Currently, dry-configurable's features propagate to dry-system, and someone may use them. Maybe dry-system's container should continue to have them. Other than this, 👍
Yeah so dry-system's extends its container with Dry::Configurable
and the gem depends on dry-configurable explicitly. So this is not a problem (luckily 😅).
@timriley are you OK with this?
@solnic Don't forget to remove dry-configurable from project.yml
! Otherwise the change in the gemspec will get overridden.
Thanks for making this change, @solnic, glad to see it go in!
This removes dependency on dry-configurable as dry-container is a lower-level gem and it shouldn't depend on dry-configurable, which is a higher-level gem. Originally, this wasn't the case, but dry-configurable has grown into a quite advanced configuration system (and will most likely continue to evolve).
Configuration needs of dry-container are very basic, they don't justify the usage of dry-configurable. Notice that dry-container is one of the oldest dry-rb gems and throughout the years its config (3 config values: namespace separator, registry and resolver) have been always the same.
Stuff works the same now: