Add support for keyword arguments in Ruby 2.7+

dry-rb / dry-core

A toolset of small support modules used throughout the @dry-rb & @rom-rb ecosystems

https://dry-rb.org/gems/dry-core/

MIT License

171 stars 34 forks source link

Add support for keyword arguments in Ruby 2.7+ #48

Closed oleander closed 3 years ago

oleander commented 3 years ago

See: https://github.com/dry-rb/dry-core/pull/46

Comment lib/dry/core/memoizable.rb:20 and/or lib/dry/core/memoizable.rb:62 for specs to fail.

Normally I would use doubles to verify method invocations (as seen in #46) but wanted to keep the changes to a minimum. Let me know if you want me to add this to the test suite. I'm currently not verifying that bar_with_kwargs is actually cached, only that the arguments are correct.

solnic commented 3 years ago

@flash-gordon could you take a look? 🙏🏻 It LGTM but I have way less experience with MRI 3.0 and kwargs madness so... 😉

oleander commented 3 years ago

@solnic Done!

solnic commented 3 years ago

@oleander I'm sorry but we have more conflicts because I merged your other PR 😅

oleander commented 3 years ago

Fixed!